Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set max locations for CTPAT locations #891

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Set max locations for CTPAT locations #891

merged 1 commit into from
Oct 17, 2023

Conversation

BenjaminMoe
Copy link
Contributor

CTPAT locations should not be allowed to have an indefinite amount of locations. Capping at 100, which should be more than enough.

@BenjaminMoe BenjaminMoe marked this pull request as ready for review October 17, 2023 15:14
@mkhraisha
Copy link
Collaborator

Where is this requirement coming from?

@BenjaminMoe BenjaminMoe merged commit 91b1445 into main Oct 17, 2023
2 checks passed
@BenjaminMoe BenjaminMoe deleted the ctpat-location branch October 17, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkhraisha mkhraisha mkhraisha approved these changes

@OR13 OR13 OR13 approved these changes

@brownoxford brownoxford brownoxford approved these changes

@mprorock mprorock Awaiting requested review from mprorock

@nissimsan nissimsan Awaiting requested review from nissimsan nissimsan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenjaminMoe @mkhraisha @brownoxford @OR13